-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Date picker crash on mui.com #14422
Comments
The demos in the docs work... so it might be specific to some styles in this demo. |
I did a quick investigation and there's a space being added to the SlideTransition classnames, perhaps involving the overrideResolver on the styled component, but I'm not being able to evolve much futher than that. Does anyone have more insights about it ? @LukasTy @flaviendelangle |
If that can help, the older docs build with the bug I found is this one mui/material-ui#43363 @romgrk could it be an unexpected side effect? |
Yes, @oliviertassinari has an open & approved PR to restore the behavior: mui/material-ui#43537 |
Oh wow, I would have never expected an extra space to cause a bug like this. I guess something broken around https://github.com/reactjs/react-transition-group/blob/2989b5b87b4b4d1001f21c8efa503049ffb4fe8d/src/CSSTransition.js#L11. Too bad that this dependency seems unmaintained, we can't fix it there. |
We should also probably think about running mui-x tests in the core repo, it would make it more safe to refactor the core. cc @mui/code-infra |
🙂 One could almost argue that X packages and @mui/material belong in the same repository. |
Looks like the issue has been resolved with this fix: mui/material-ui#43537 and is no loner present in the deployed documentation. |
@oliviertassinari: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey. |
Steps to reproduce
Steps:
Current behavior
Screen.Recording.2024-09-01.at.00.29.02.mov
Context
https://x.com/bweston92/status/1829792875955028046
The text was updated successfully, but these errors were encountered: