Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lru-cache to ^11.0.1 #14437

Closed
wants to merge 1 commit into from
Closed

Bump lru-cache to ^11.0.1 #14437

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 1, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
lru-cache ^10.4.3 -> ^11.0.1 age adoption passing confidence

Release Notes

isaacs/node-lru-cache (lru-cache)

v11.0.1

Compare Source

v11.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Sep 1, 2024
@@ -37,7 +37,7 @@
"@mui/x-data-grid-premium": "workspace:*",
"chance": "^1.1.12",
"clsx": "^2.1.1",
"lru-cache": "^10.4.3"
"lru-cache": "^11.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui/xgrid can you confirm if my assumption that we can't bump this dependency is correct?
@mui/x-data-grid-generator has engines.node set to >=14 and this major dependency bump now requires >=20 🤔
Should we update renovate rule to include bumps only until v11?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is now green as MUI Core has bumped this dep to v11, but I'm still unsure about @mui/data-grid-generator working on node <20 with these changes.
@mui/xgrid Could you please check it? 🤔 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator package is not meant to be used by our users, so bumping the "engines.node" for it is not a breaking change.
On the other hand, I don't see a reason to upgrade this package. I prefer to keep using v10.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's close this PR then. 👌
If a new version is released, we can look into blocking updates with a renovate config. 👍

@LukasTy LukasTy added the on hold There is a blocker, we need to wait label Sep 4, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2024
@renovate renovate bot changed the title Bump lru-cache to ^11.0.0 Bump lru-cache to ^11.0.1 Sep 19, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2024
@mui-bot
Copy link

mui-bot commented Sep 19, 2024

Deploy preview: https://deploy-preview-14437--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3dd8bea

@LukasTy LukasTy closed this Sep 19, 2024
@LukasTy LukasTy deleted the renovate/lru-cache-11.x branch September 19, 2024 21:17
Copy link
Contributor Author

renovate bot commented Sep 19, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 11.x releases. But if you manually upgrade to 11.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies on hold There is a blocker, we need to wait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants