Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix demos acting flaky in Argos #15372

Open
LukasTy opened this issue Nov 11, 2024 · 6 comments
Open

[docs] Fix demos acting flaky in Argos #15372

LukasTy opened this issue Nov 11, 2024 · 6 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@LukasTy
Copy link
Member

LukasTy commented Nov 11, 2024

Some demos are producing flaky results in Argos.
Sometimes we approve the broken versions and then have to re-approve the proper version of those snapshots in multiple follow-up PRs.
Here are examples of the latest demos producing issues: https://app.argos-ci.com/mui/mui-x/builds/26329/118165897, https://app.argos-ci.com/mui/mui-x/builds/26330/118217890.

Search keywords:

@LukasTy LukasTy added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Nov 11, 2024
@JCQuintas
Copy link
Member

Could this be an issue with the v7 branch and the config? I've run the migration scrips locally in master and v7 and the outputs are different for some of these tests

@LukasTy
Copy link
Member Author

LukasTy commented Nov 11, 2024

As far as I remember, at least he PopularFeaturesDemo was flaky before the start of the master<->v7.x "tango". 🤔

@JCQuintas
Copy link
Member

Yeah, so from the argos config, it uses master as the base, so I GUESS if on a v7 PR we accept the changes, they will be the new "master" changes.

@LukasTy
Copy link
Member Author

LukasTy commented Nov 11, 2024

Yeah, so from the argos config, it uses master as the base, so I GUESS if on a v7 PR we accept the changes, they will be the new "master" changes.

Hasn't Argos been semi recently updated to work smart with the branches? 🤔

@JCQuintas
Copy link
Member

Idk, their settings doesn't have anything related to that: https://app.argos-ci.com/mui/mui-x/settings

@LukasTy
Copy link
Member Author

LukasTy commented Nov 11, 2024

Idk, their settings doesn't have anything related to that: https://app.argos-ci.com/mui/mui-x/settings

@JCQuintas I was referring to https://argos-ci.com/changelog/2024-10-08-multi-branches. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants