Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Implement Cell editing #203

Closed
oliviertassinari opened this issue Aug 21, 2020 · 13 comments · Fixed by #1287
Closed

[DataGrid] Implement Cell editing #203

oliviertassinari opened this issue Aug 21, 2020 · 13 comments · Fixed by #1287
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature linked in docs The issue is linked in the docs, so completely skew the upvotes new feature New feature or request
Milestone

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 21, 2020

Benchmark

This feature is also related to the editable row #204.

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request labels Aug 21, 2020
@raajmayukh
Copy link

raajmayukh commented Nov 18, 2020

@oliviertassinari Can I get an idea on ETA for this enhancement? I do see that row editing is planned for Q4, so would cell editing be part of that enhancement as it's related?
https://github.com/mui-org/material-ui-x/projects/1

@oliviertassinari
Copy link
Member Author

@raajmayukh We are focusing on #201. This one will probably land in 2021.

@rgins16
Copy link

rgins16 commented Nov 27, 2020

@oliviertassinari Are you planning on implementing this for columns as well? I would like to change the headerName.

@oliviertassinari
Copy link
Member Author

@rgins16 We won't handle the header in the first iteration. I can't say for the following ones. The most common use case is to change the cells, only. So far, we plan this feature for Q1 2021.

@Samurus
Copy link

Samurus commented Nov 30, 2020

@oliviertassinari I miss primefaces/primereact in the list for Benchmark: https://primefaces.org/primereact/showcase/#/datatable/edit
It seems to be free and open source which is a great plus.

@oliviertassinari oliviertassinari added the linked in docs The issue is linked in the docs, so completely skew the upvotes label Nov 30, 2020
@oliviertassinari oliviertassinari added this to the Sprint 10 milestone Feb 8, 2021
@dtassone dtassone self-assigned this Feb 10, 2021
@oliviertassinari oliviertassinari modified the milestones: Sprint 10, Sprint 11 Feb 15, 2021
@oliviertassinari oliviertassinari modified the milestones: Sprint 11, Sprint 12 Mar 1, 2021
@oliviertassinari
Copy link
Member Author

@Samurus Thanks for linking the reference to primeface. Mind that the plan is to make this feature in the MIT version: https://material-ui.com/components/data-grid/getting-started/#feature-comparison.

@arheinjohnson
Copy link

Any idea how soon this will be implemented?

@dtassone
Copy link
Member

We have merged the last PR for the implementation. We still have to finish the documentation, and if it all goes well it should be released next week or the week after.

@raajmayukh
Copy link

@oliviertassinari @dtassone Thanks guys for tackling that. I know I had reached out in November last year for this feature and subsequently implemented through react-table. But this is something that I would check to see if this one works even better. Thanks again. Cheers!!

@angelhd1999
Copy link

We have merged the last PR for the implementation. We still have to finish the documentation, and if it all goes well it should be released next week or the week after.

@dtassone
I've been doing a project with Material-UI for some time and if I can take advantage of this it would be great.
Could you tell me if cell editing will allow advanced ways of editing like selecting between different options or a date picker?
I ask it to know if I have to think of a different approach or it is worth waiting for me.
Thank you very much for the effort you make.

@khanzzirfan
Copy link

Just FYI: I have used the alpha release of the cell edit feature. Its looks good. Thank you for the support. But below are few things doesn't work.

@oliviertassinari
Copy link
Member Author

@khanzzirfan Related to #1320. If you have a reproduction, please open a new issue.

@oliviertassinari
Copy link
Member Author

The documentation for this feature can now be found at https://material-ui.com/components/data-grid/editing/#cell-editing.

@oliviertassinari oliviertassinari added the feature: Editing Related to the data grid Editing feature label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature linked in docs The issue is linked in the docs, so completely skew the upvotes new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants