-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Leaking MUI 5 Errors #2184
Comments
Do you still see any warning using the last alpha version? v4.0.0-alpha.34 was released yesterday to fix support with v4. |
Please provide a minimal reproduction test case with the latest version. This would help a lot 👷 . |
@emily-ellevation you need to upgrade to use v4.0.0-alpha.34. |
@m4theushw @oliviertassinari upgrading to .34 resolved all errors except for Thanks so much for the speedy resolution of this issue. While the above may be a 'leaking' error, for our purposes we can resolve by changing our internal component that wraps |
This warning is coming from the Grid component, not the DataGrid. You need to upgrade the core package. |
👋 Thanks for using Material-UI! We use GitHub issues exclusively as a bug and feature requests tracker, however, For support, please check out https://material-ui.com/getting-started/support/. Thanks! If you have a question on StackOverflow, you are welcome to link to it here, it might help others. |
Ah I missed https://github.com/mui-org/material-ui/pull/24078/files in 4.12 of the main pkg and assumed this was another leak somehow -- thank you! |
Hello! We're using the DataGrid at 4.0.0-alpha.29 and starting to see console errors that are seemingly related to the release of v5. Many of our errors seem to originate from the styles package despite it being on
4.11.4
. Initially we started seeing errors aboutcreateMuiTheme
being deprecated tocreateTheme
. I'm wondering where in the dependency graph these are introduced so that we might lock whatever we can to stay in a stable state until ready to upgrade to 5.I understand this is an alpha package and it may not be reasonable to expect it to be airtight in this way but want to see if there's anything I'm missing to mitigate these issues.
I've seen #2106 and #2142 but I'm seeing additional warnings.
When running code:
When running tests:
Could these be related to the dependence on MUI utils package @ 5?
Thanks so much, excited to get going with v5!
Current Behavior 😯
Expected Behavior 🤔
Steps to Reproduce 🕹
Steps:
Context 🔦
Your Environment 🌎
`npx @material-ui/envinfo`
Order id 💳
The text was updated successfully, but these errors were encountered: