Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Leaking MUI 5 Errors #2184

Closed
1 of 2 tasks
emily-ellevation opened this issue Jul 21, 2021 · 7 comments
Closed
1 of 2 tasks

[DataGrid] Leaking MUI 5 Errors #2184

emily-ellevation opened this issue Jul 21, 2021 · 7 comments
Labels
support: Stack Overflow Please ask the community on Stack Overflow

Comments

@emily-ellevation
Copy link

Hello! We're using the DataGrid at 4.0.0-alpha.29 and starting to see console errors that are seemingly related to the release of v5. Many of our errors seem to originate from the styles package despite it being on 4.11.4. Initially we started seeing errors about createMuiTheme being deprecated to createTheme. I'm wondering where in the dependency graph these are introduced so that we might lock whatever we can to stay in a stable state until ready to upgrade to 5.
I understand this is an alpha package and it may not be reasonable to expect it to be airtight in this way but want to see if there's anything I'm missing to mitigate these issues.

I've seen #2106 and #2142 but I'm seeing additional warnings.

When running code:
Screen Shot 2021-07-21 at 4 49 43 PM

When running tests:
Screen Shot 2021-07-21 at 5 04 53 PM
Screen Shot 2021-07-21 at 5 07 41 PM

Could these be related to the dependence on MUI utils package @ 5?
Screen Shot 2021-07-21 at 3 53 51 PM

Thanks so much, excited to get going with v5!

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔

Steps to Reproduce 🕹

Steps:

Context 🔦

Your Environment 🌎

`npx @material-ui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.

Order id 💳

@emily-ellevation emily-ellevation added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 21, 2021
@m4theushw
Copy link
Member

Do you still see any warning using the last alpha version? v4.0.0-alpha.34 was released yesterday to fix support with v4.

@oliviertassinari oliviertassinari added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 22, 2021
@oliviertassinari
Copy link
Member

Please provide a minimal reproduction test case with the latest version. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 24, 2021

We're using the DataGrid at 4.0.0-alpha.29

@emily-ellevation you need to upgrade to use v4.0.0-alpha.34.

@emily-ellevation
Copy link
Author

@m4theushw @oliviertassinari upgrading to .34 resolved all errors except for
Screen Shot 2021-07-26 at 9 59 42 AM

Thanks so much for the speedy resolution of this issue. While the above may be a 'leaking' error, for our purposes we can resolve by changing our internal component that wraps <Grid> to use justifyContent

@m4theushw
Copy link
Member

m4theushw commented Jul 26, 2021

This warning is coming from the Grid component, not the DataGrid. You need to upgrade the core package.

@oliviertassinari oliviertassinari added support: Stack Overflow Please ask the community on Stack Overflow and removed status: waiting for author Issue with insufficient information labels Jul 26, 2021
@support
Copy link

support bot commented Jul 26, 2021

👋 Thanks for using Material-UI!

We use GitHub issues exclusively as a bug and feature requests tracker, however,
this issue appears to be a support request.

For support, please check out https://material-ui.com/getting-started/support/. Thanks!

If you have a question on StackOverflow, you are welcome to link to it here, it might help others.
If your issue is subsequently confirmed as a bug, and the report follows the issue template, it can be reopened.

@emily-ellevation
Copy link
Author

emily-ellevation commented Jul 26, 2021

This warning is coming from the Grid component, not the DataGrid. You need to upgrade the core package.

Ah I missed https://github.com/mui-org/material-ui/pull/24078/files in 4.12 of the main pkg and assumed this was another leak somehow -- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: Stack Overflow Please ask the community on Stack Overflow
Projects
None yet
Development

No branches or pull requests

3 participants