-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Improve x-grid-data-generator management #226
Comments
One possible approach for the future. The package is for demo only purposes, so simplicity should be prioritized: It could be interesting to bring in the folder import structure we have in the main repository and allow to do things like: import { useDemoData } from '@material-ui/x/dataGenerator'; // non MIT license To remove the need for more packages (the fewer, the less mess to manage). Also, considering that we might need a data generator for other components, like a chart or a scheduler, I would suggest that we make the above the only valid import, avoiding the need to duplicate it between different packages as we have done in #887 for the sake of simplicity (but I don't think that it will scale). |
I assume we should also follow the same pater for the And the MIT version will be |
@DanailH I don't think that it's an option because we need the nested import to match the exported name, this would work: import XGrid from '@material-ui/x/XGrid'; In any case, I think that we can delay the conversion to the point in time we add a second component. We could also very well imagine removing individual packages
Just a thought, no idea if it's better. |
From a user perspective, I think it's nice to be able to install just the required component. |
@dtassone Yeah, I think that it comes down to what developers most often need. Basically, we need to draw the distribution of the number of imported packages among our userbase to know. I doubt it's data we can easily access to. GA could yield some indicators. A survey might be interesting too.
I think that by definition, the usage of advanced components makes 1 less likely than for generic design system components. However, I wouldn't be surprised if the data grid ends-up very frequently used, relatively to the other core components (the popularity of react-table and of the Table are two great indicators of the potential, if we execute correctly). At the ends of the day, I think that it comes down to: bundled packages pros:
individual packages pros:
|
@oliviertassinari Is this issue still relevant after we renamed the packages? |
Can this package really be MIT since it needs a non-MIT package to work ? |
Considering the package is MIT, I don't think that it should be prefixed with
x-
, hence the proposal in the title.The text was updated successfully, but these errors were encountered: