Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4-docs] wrong content in docsearch meta #2664

Closed
2 tasks done
siriwatknp opened this issue Sep 21, 2021 · 2 comments
Closed
2 tasks done

[v4-docs] wrong content in docsearch meta #2664

siriwatknp opened this issue Sep 21, 2021 · 2 comments
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation MUI Core v4.x

Comments

@siriwatknp
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

docsearch team mentioned in this PR that some of the links in v4 has wrong content.

Only the urls for data-grid has wrong content.

<meta name="docsearch:version" content="master">

Expected behavior 🤔

It should be

<meta name="docsearch:version" content="v4">

Steps to reproduce 🕹

Steps:

  1. checkout https://v4.mui.com/components/data-grid/
  2. in element devtool, search for docsearch

Context 🔦

No response

Your environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID 💳 (optional)

No response

@siriwatknp siriwatknp added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 21, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 21, 2021

@siriwatknp I work on this in #2657. I think that the next step for this issue is to update https://github.com/mui-org/material-ui/blob/v4.x/docs/public/_redirects#L151-L159 to point to the docs-v4 branch.


Also note that I fixed a different issue with Algolia on #2655 (it's similar to this one, but for v5, this time, not v4).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work MUI Core v4.x docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 21, 2021
@cherniavskii
Copy link
Member

It's set to "v4" now:
Screenshot 2022-06-29 at 13 19 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation MUI Core v4.x
Projects
None yet
Development

No branches or pull requests

3 participants