-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Carousel component #3601
Comments
AFAIC the best carousel lib is still https://github.com/nolimits4web/Swiper |
You can make a passable carousel using the mobile stepper (this is a modified version of the docs example): https://codesandbox.io/s/material-demo-gq5rk (The dots could do with a better colours, but I didn't attempt to restyle them.) There is also: https://mui.wertarbyte.com/#material-auto-rotating-carousel |
The carousel component is needed for my Application also. Would be great if it comes up in the next release. |
@oliviertassinari How do you prioritize the "waiting for +1", looks like this is the most upvoted for a long time now |
We display the Carousel as part of MUI X in the roadmap, I propose we transfer this issue to MUI X, so the Core team can focus on what has been making it successful so far: https://mui.com/discover-more/roadmap/#new-components cc @mui-org/core @mui-org/x for thoughts. This says nothing about the MIT vs. not-MIT aspect of it, but either about if it should be part of Core or X. I would argue X because 1. design is secondary to a Carousel, 2. it's not fundamental to be part of a design system, 3. there are OSS projects only doing carousel. |
Makes sense to have the component in MUI-X. A carousel is a fairly advanced component, with multiple kinds of user interactions and behaviours, and possibly a high demand for customisation. +1 on moving the issue to X. |
@joserodolfofreitas The things that were making me doubt is that:
It challenges the difference between MUI Core and MUI X. For sure the difference is not about which team has more bandwidth as it's a bull**it argument, have people change teams, and problem solved. So far, the rationale was:
We can keep iterating on it, added to https://mui-org.notion.site/MUI-Core-vs-MUI-X-b96e01a6239f423e83d01efeaad019fb |
I see your points, it's indeed not an easy call. edit: Landing pages is the majority though, we can't shake that. |
There’s also this project: https://github.com/nanxiaobei/react-slide-routes, which implements a popular use case for a carousel-like component. |
Summary 💡
Add a carousel component to display images
Examples 🌈
Motivation 🔦
One of the most asked items in https://material-ui.com/blog/2020-developer-survey-results/#5-how-can-we-improve-material-ui-for-you.
Benchmark
The text was updated successfully, but these errors were encountered: