Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Am I using what's new in #3687 to export collapsed data correctly? #3913

Closed
2 tasks done
lincolnmqs opened this issue Feb 10, 2022 · 2 comments
Closed
2 tasks done
Labels
component: data grid This is the name of the generic UI component, not the React module! support: commercial Support request from paid users

Comments

@lincolnmqs
Copy link

Order ID 💳

35305

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

The problem in depth 🔍

I would like to use update #3687 to export even collapsed table data. However, when there are selected checkboxSelection, export only the selected ones. Export all only if all are not selected.

Code: https://codesandbox.io/s/xenodochial-newton-qj6fv?file=/src/App.js:4021-4077

Your environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@lincolnmqs lincolnmqs added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels Feb 10, 2022
@flaviendelangle
Copy link
Member

image

You are describing the default behavior, you don't have to use #3687 at all.

@joserodolfofreitas joserodolfofreitas removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 10, 2022
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Feb 10, 2022
@shawnlee-info
Copy link

shawnlee-info commented Feb 11, 2025

image

You are describing the default behavior, you don't have to use #3687 at all.

I think you misunderstood his question, he's not affirming your default behavior, he's describing the issue, just another victim.

The "default behavior" I honestly just don't get it, why selecting row(s) has anything to do with the export? especially users can easily click a row on the screen, they don't even know they're selecting a row, but Export only gets one row. Watch real users using it you'll know Export means get a copy of ALL data to them in most cases.

I fell into this pitfall too recently, and just for anyone who needs, if selecting a row isn't a necessary feature, you can simply disable it so alwasy exports all rows disableRowSelectionOnClick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! support: commercial Support request from paid users
Projects
None yet
Development

No branches or pull requests

5 participants