Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Scrolling demo doesn't work after upgrading to React 18 #6002

Closed
2 tasks done
cherniavskii opened this issue Sep 2, 2022 · 0 comments · Fixed by #6489
Closed
2 tasks done

[data grid] Scrolling demo doesn't work after upgrading to React 18 #6002

cherniavskii opened this issue Sep 2, 2022 · 0 comments · Fixed by #6489
Assignees
@cherniavskii
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@cherniavskii
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Clicking navigation buttons does nothing

Expected behavior 🤔

Clicking navigation buttons should move focus to the next cell, like it worked with React 17: https://codesandbox.io/s/adoring-dawn-6jggho

Steps to reproduce 🕹

Link to live example:

Steps:

  1. Go to https://codesandbox.io/s/romantic-ishizaka-j0qukz
  2. Click on any cell
  3. Click "Right"
  4. See that there's no focused cell anymore

Context 🔦

This started to happed after merging #4155

Your environment 🌎

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID 💳 (optional)

No response
@cherniavskii cherniavskii added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Sep 2, 2022
@m4theushw m4theushw moved this to 📋 Backlog in MUI X Data Grid Sep 9, 2022
@m4theushw m4theushw moved this from 📋 Backlog to 🔖 Ready in MUI X Data Grid Sep 9, 2022
@cherniavskii cherniavskii self-assigned this Oct 13, 2022
@cherniavskii cherniavskii moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Oct 13, 2022
@cherniavskii cherniavskii mentioned this issue Oct 13, 2022
Merged
@cherniavskii cherniavskii moved this from 🏗 In progress to 🔖 Ready in MUI X Data Grid Mar 28, 2023
@cherniavskii cherniavskii moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Apr 4, 2023
@cherniavskii cherniavskii moved this from 🏗 In progress to 👀 In review in MUI X Data Grid Apr 4, 2023
@cherniavskii cherniavskii mentioned this issue May 2, 2023
Closed
2 tasks
@cherniavskii cherniavskii moved this from 👀 In review to ✅ Done in MUI X Data Grid May 2, 2023
@romgrk romgrk mentioned this issue May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherniavskii cherniavskii

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Fix scrolling demo to work with React 18 cherniavskii/mui-x
1 participant
@cherniavskii