Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LocalizationProvider] changing locale doesn't update GridToolbarFilterButton #6326

Closed
2 tasks done
samordoch opened this issue Sep 29, 2022 · 2 comments
Closed
2 tasks done
Labels
component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@samordoch
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

i have a custom toolbar
image
that is under themeProvider with local
image
when I change locale the filter button title and text is not affected
image

Expected behavior 🤔

button text should be translated as in the row count below

Steps to reproduce 🕹

Link to live example:

Steps:

  1. use a custom toolbar with GridToolbarFilterButton
  2. surround with theme provider
  3. change local

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.22000
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.18 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.1.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.22000.120.0), Chromium (105.0.1343.53)
  npmPackages:
    @emotion/react: ^11.9.0 => 11.9.0
    @emotion/styled: ^11.8.1 => 11.8.1
    @mui/base:  5.0.0-alpha.75
    @mui/core-downloads-tracker:  5.10.4
    @mui/icons-material: ^5.8.2 => 5.8.2
    @mui/lab: ^5.0.0-alpha.76 => 5.0.0-alpha.76
    @mui/material: ^5.6.0 => 5.10.4
    @mui/private-theming:  5.10.3
    @mui/styled-engine:  5.10.4
    @types/react: ^17.0.43 => 17.0.43
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    styled-components: ^5.3.5 => 5.3.5
    typescript: ^4.5.5 => 4.5.5

Order ID 💳 (optional)

No response

@samordoch samordoch added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 29, 2022
@alexfauquette
Copy link
Member

Could it be linked to #4119

I don't see a specific problem on filtering button. It is just late of 1 rendering loop like others in this demo
https://codesandbox.io/s/elegant-sea-1x5fxj?file=/demo.tsx

@m4theushw
Copy link
Member

I'm closing since it's the same issue from #4119. Please subscribe to it to get notified when a fix gets released.

@m4theushw m4theushw added duplicate This issue or pull request already exists component: data grid This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants