-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Input lag in GridToolbarQuickFilter on slowly typing #6783
Comments
I managed to reproduce the bug in the DataGrid too. msedge_G6c63Qi4qY.mp4 |
@m4theushw, do you know when will it get fixed or maybe workaround for the problem? |
We can't provide an estimate yet. We still need to investigate what is causing this problem. It could related to the render phase taking too much time. The workaround we can suggest is to increase the debounce with <GridToolbarQuickFilter debounceMs={1000} /> In https://mui.com/x/react-data-grid/filtering/#parsing-values there's a demo showing how to customize the quick filter to pass this prop. |
Is investigation continues? If not, i think issue can be closed because the workaround helped us a lot. |
This issue makes the search experience really not great, thanks for raising 👍 ! Off-topic While this issue is about "Correct printing at any speed", it feels well related to my comment in #9120 (comment) with @romgrk. We have a 500ms input debounce that feels like a massive time waste, it makes it impossible for the search to feel responsive. mui-x/packages/grid/x-data-grid/src/components/toolbar/GridToolbarQuickFilter.tsx Line 74 in df534be
mui-x/packages/grid/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx Line 8 in 82ab9c0
Even Google Maps reacts a lot faster to search queries. I think that we could explore this instead:
|
Linked #9157 |
Great to see this bug fixed 👌 I created an issue for the above idea #9657 |
Duplicates
Latest version
Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/pedantic-field-o02961?file=/src/App.jshttps://codesandbox.io/s/adoring-lewin-i471nc?file=/src/App.js
Steps:
Click to gif:
Current behavior 😯
Sometimes quick filter Input "eats" the last characters (with any debounceMs).
Expected behavior 🤔
Correct printing at any speed.
Context 🔦
There was a similar problem in #5283. Maybe GridToolbarQuickFilter need same fixed as #5646.
Your environment 🌎
npx @mui/envinfo
Order ID 💳 (optional)
48449
The text was updated successfully, but these errors were encountered: