Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Column selector crashes with 3 hidden columns #856

Closed
2 tasks done
oliviertassinari opened this issue Jan 16, 2021 · 1 comment · Fixed by #875
Closed
2 tasks done

[DataGrid] Column selector crashes with 3 hidden columns #856

oliviertassinari opened this issue Jan 16, 2021 · 1 comment · Fixed by #875
Assignees
@DanailH
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Milestone
Sprint 9

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 16, 2021 •
edited
Loading

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Crash

Expected Behavior 🤔

No crash

Steps to Reproduce 🕹

Steps:

  1. Open https://material-ui.com/components/data-grid/columns/#column-selector
  2. Have 3 columns hidden
  3. Capture d’écran 2021-01-16 à 01 19 58

It fails here

Capture d’écran 2021-01-16 à 01 20 46

Context 🔦

It's a follow-up on #345, @DanailH was leading the effort on it.
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jan 16, 2021
@DanailH
Copy link
Member

DanailH commented Jan 18, 2021

Ok this is strange as when I tested it I wasn't able to reproduce that error but I'll check it now and aim to fix it ASAP.

@DanailH DanailH self-assigned this Jan 18, 2021
@oliviertassinari oliviertassinari added this to the Sprint 9 milestone Jan 18, 2021
This was referenced Jan 18, 2021
Merged
Closed
@DanailH DanailH mentioned this issue Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanailH DanailH

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

[DataGrid] Fix column selector crash when hiding columns DanailH/material-ui-x
2 participants
@oliviertassinari @DanailH