Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Update Next.js example to use ESM #88

Open
oliviertassinari opened this issue May 16, 2024 · 0 comments · May be fixed by #114 or #152
Open

[examples] Update Next.js example to use ESM #88

oliviertassinari opened this issue May 16, 2024 · 0 comments · May be fixed by #114 or #152
Assignees
@siriwatknp
Labels
examples Relating to /examples status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 16, 2024 •
edited
Loading

Summary

pigment-css/examples/pigment-css-nextjs-ts/next.config.js

Line 1 in b4e2d77

const { withPigment, extendTheme } = require('@pigment-css/nextjs-plugin');

is using CJS. But npx create-next-app@latest gives you a next.config.mjs file. So we need to update this example.

Motivation

Make it easier to copy and paste the example to an existing project.
@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer examples Relating to /examples labels May 16, 2024
brijeshb42 added a commit to brijeshb42/pigment-css that referenced this issue May 30, 2024
@brijeshb42
Convert example to mjs syntax
6d90d26 
Fixes mui#88
@brijeshb42 brijeshb42 linked a pull request May 30, 2024 that will close this issue
Open
1 task
brijeshb42 added a commit to brijeshb42/pigment-css that referenced this issue Jun 17, 2024
@brijeshb42
Convert example to mjs syntax
e009961 
Fixes mui#88
brijeshb42 added a commit to brijeshb42/pigment-css that referenced this issue Jun 17, 2024
@brijeshb42
Convert example to mjs syntax
e77eff4 
Fixes mui#88
brijeshb42 added a commit to brijeshb42/pigment-css that referenced this issue Jun 21, 2024
@brijeshb42
Convert example to mjs syntax
53605f1 
Fixes mui#88
@oliviertassinari oliviertassinari linked a pull request Oct 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
examples Relating to /examples status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Milestone
No milestone
2 participants
@oliviertassinari @siriwatknp