-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FileInput Component #1395
Comments
@prakhargupta1 could you please explain:
It might be easier if at least one e2e scenario would be added how this feature is suppose to be used |
For now, let's just support uploading files through REST API. So it can act like the Button component having onClick event.
Can we support All file formats(<5Mb) for now and support restrictions later?
Example here |
@prakhargupta1 could you provide a more specific example or at least outline which part in the entire documentation refers to the actual usecase? In the link you shared I can only find explanation that the widget allows uploading files but it doesn't mention how those files can later be used:
When I say "e2e scenario" I'm thinking about something like following:
IMO this is quite a large feature both in scope and functionality and we should have a bit more specific information |
I guess that for now we can just allow users to add a local file to a file input, client side, and then the file object can be accessed in the bindings panel, for example? |
That's what I'm trying to understand because doing that client-side only vs uploading to the backend are significantly different tasks |
as @apedroferreira suggests, intuitively I think it could make sense separating the file input component from the file uploading. Perhaps we could start with a benchmark?
Then try to figure out the trade-offs associated with the method
I think I'd at least be interested in how the retool/appsmith/openblocks family compares to dynaboard |
No UI, just the Native File uploader should come.
Both of these. Like Pedro mentioned, the file content should be available in bindings for it to be used anywhere in an API. We should show all info related to file like name, file type, base64 string in bindings. Eg: Check the video at 4:34 Let's just first support file uploading in the minimal way possible. I'll see how Dynaboard does it. |
@prakhargupta1 what Pedro suggested is client side file upload - which basically means we are not uploading file anywhere except that we open that file for reading in browser. What you asked "For now, let's just support uploading files through REST API." is a full backend support for uploading and storing files. Minimal way possible, I'd say is client side file read - would that be enough? |
I meant the same: The file is available in the browser to be used as a binding, so that it can be used in a query to be uploaded through a REST API. |
In v2, we can do the following:
How it works can also be found here: https://docs.superblocks.com/applications/components-library/file-picker |
Summary 💡
When building admin application, a feature uploading files - like csv or etcetera - is often necessary.
Examples 🌈
https://retool.com/components/file-button
https://retool.com/components/file-input
Motivation 🔦
No response
The text was updated successfully, but these errors were encountered: