-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload of a page editor always switches to the first page #1551
Comments
Thanks for catching this, I'll look into it! |
We should also look if it's still possible to navigate to a Toolpad editor url with query parameters. |
You mean as a new feature? We didn't have any case where it was possible to do that yet, right? |
I think it was possible for pages, but I may be wrong. I'm pretty sure it didn't use to eliminate them. Not sure if also it did something with them. |
It's a regression, probably a recent one, I confused me a couple of timed this week improving a few of the toolpad apps. |
Duplicates
Latest version
Steps to reproduce 🕹
Steps:
Current behavior 😯
The url switches to the first page
Expected behavior 🤔
The url stays on the selected page
Context 🔦
This line is the culprit https://github.com/mui/mui-toolpad/blob/4f4f4f1e80c943098be66a9417f455006a9ae1dc/packages/toolpad-app/src/toolpad/AppEditor/index.tsx#L58
This will need an integration test
Your environment 🌎
No response
The text was updated successfully, but these errors were encountered: