Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload of a page editor always switches to the first page #1551

Closed
2 tasks done
Janpot opened this issue Jan 13, 2023 · 5 comments · Fixed by #1565
Closed
2 tasks done

Reload of a page editor always switches to the first page #1551

Janpot opened this issue Jan 13, 2023 · 5 comments · Fixed by #1565
Assignees
Labels
bug 🐛 Something doesn't work regression A bug, but worse

Comments

@Janpot
Copy link
Member

Janpot commented Jan 13, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Steps:

  1. Open the editor on an app with multiple pages
  2. Open any of the pages other than the first page
  3. Hit reload

Current behavior 😯

The url switches to the first page

Expected behavior 🤔

The url stays on the selected page

Context 🔦

This line is the culprit https://github.com/mui/mui-toolpad/blob/4f4f4f1e80c943098be66a9417f455006a9ae1dc/packages/toolpad-app/src/toolpad/AppEditor/index.tsx#L58

This will need an integration test

Your environment 🌎

No response

@Janpot Janpot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
@apedroferreira
Copy link
Member

Thanks for catching this, I'll look into it!

@Janpot
Copy link
Member Author

Janpot commented Jan 13, 2023

We should also look if it's still possible to navigate to a Toolpad editor url with query parameters.

@apedroferreira
Copy link
Member

We should also look if it's still possible to navigate to a Toolpad editor url with query parameters.

You mean as a new feature? We didn't have any case where it was possible to do that yet, right?
If so I'll create a new issue for it.

@Janpot
Copy link
Member Author

Janpot commented Jan 13, 2023

I think it was possible for pages, but I may be wrong. I'm pretty sure it didn't use to eliminate them. Not sure if also it did something with them.

@oliviertassinari oliviertassinari added the regression A bug, but worse label Jan 14, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 14, 2023

It's a regression, probably a recent one, I confused me a couple of timed this week improving a few of the toolpad apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants