Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page tab to right-side panel #2311

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Jul 14, 2023

  • Add Page tab
  • Remove "Settings" option for pages in left-side panel

Closes #2095?
(or should we not close it to separate the queries to another panel, or should we create a separate issue for that?)

Screen.Recording.2023-07-14.at.17.26.18.mov

@apedroferreira apedroferreira added design: ux Design enhancement This is not a bug, nor a new feature labels Jul 14, 2023
@apedroferreira apedroferreira self-assigned this Jul 14, 2023
@prakhargupta1
Copy link
Member

We can link it to be closed. Moving queries to the left is being explored in #2138

@apedroferreira apedroferreira merged commit fc8a023 into mui:master Jul 18, 2023
1 check passed
@apedroferreira apedroferreira deleted the page-tab branch July 18, 2023 12:02
@Janpot
Copy link
Member

Janpot commented Jul 19, 2023

@apedroferreira Few things I ran into when further testing

  • the page tab doesn't get activated when I deselect a component (e.g. click the page margin).
  • it's pretty useless to be able to select the component tab when no component is selected. perhaps we should disable it in that case?

@apedroferreira
Copy link
Member Author

apedroferreira commented Jul 19, 2023

  • the page tab doesn't get activated when I deselect a component (e.g. click the page margin).
  • it's pretty useless to be able to select the component tab when no component is selected. perhaps we should disable it in that case?

Sure these are fair points, maybe they make things a little bit more intuitive.
I'll try these 2 changes to see how it feels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: ux Design enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page tab to be shown in the right panel
3 participants