Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting a custom icon for code components #2384

Open
2 tasks done
dai-chao opened this issue Jul 27, 2023 · 3 comments
Open
2 tasks done

Allow setting a custom icon for code components #2384

dai-chao opened this issue Jul 27, 2023 · 3 comments
Labels
new feature New feature or request scope: toolpad-studio Abbreviated to "studio" waiting for 👍 Waiting for upvotes

Comments

@dai-chao
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

image
When creating custom components, the icons are fixed. Is it possible to make both the names and icons configurable?
image
The same icon.

Examples 🌈

image

Motivation 🔦

image
@dai-chao dai-chao added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 27, 2023
@Janpot Janpot added new feature New feature or request waiting for 👍 Waiting for upvotes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 27, 2023
@Janpot Janpot changed the title Create a new Code Component Allow setting a custom icon for code components Jul 27, 2023
@Janpot Janpot mentioned this issue Aug 21, 2023
Open
8 tasks
@JerryWu1234
Copy link
Contributor

I can to try this? @Janpot

@Janpot
Copy link
Member

Janpot commented Aug 29, 2023

I'm not entirely sure how the implementation will work. One idea we had was to add an icon property in the createComponent function, but I'm not sure which format it should be. A React component, or a React node, or a url, or something else.

@JerryWu1234
Copy link
Contributor

I'm not entirely sure how the implementation will work. One idea we had was to add an icon property in the createComponent function, but I'm not sure which format it should be. A React component, or a React node, or a url, or something else.

@Janpot, How many icons do you want the user to choose?
I saw more than two thousand in the @mui/icon.
It could be a performance problem if there are two thousand.

@JerryWu1234 JerryWu1234 mentioned this issue Sep 1, 2023
Closed
4 tasks
@prakhargupta1 prakhargupta1 added the scope: toolpad-studio Abbreviated to "studio" label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New feature or request scope: toolpad-studio Abbreviated to "studio" waiting for 👍 Waiting for upvotes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Janpot @JerryWu1234 @dai-chao @prakhargupta1