Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename nodes #3168

Closed
oliviertassinari opened this issue Feb 6, 2024 · 4 comments · Fixed by #3336
Closed

Ability to rename nodes #3168

oliviertassinari opened this issue Feb 6, 2024 · 4 comments · Fixed by #3336
Labels
design: ux Design good first issue Great for first contributions. Enable to learn the contribution process. priority: low To delay as much as possible

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 6, 2024

Summary

We used to be able to rename nodes, it seems that we can't anymore

Examples

No response

Motivation

I noticed this in oliviertassinari/mui-olivier-tools#6. I wasn't should about using select.value for my binding, I was going to rename the node from select to org.

BTW, it was super fast to build, I guess if I had used Pro-code, it would have been as fast, but for a person who doesn't know a lot about frontend but still has an engineer mind, damn 👌.

Search keywords: rename nodes

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer priority: low To delay as much as possible labels Feb 6, 2024
@apedroferreira
Copy link
Member

apedroferreira commented Feb 6, 2024

You can still do it by double-clicking on the node in that list, right?
I guess we used to have the option too on the right, not sure when we removed it or if there was a reason to...

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 6, 2024

You can still do it by double-clicking on the node in that list

Oh, I didn't realize. I context menu on this tree view with a rename option could be nice.

@Janpot Janpot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 8, 2024
@Janpot
Copy link
Member

Janpot commented Feb 8, 2024

Let's add a menu to the tree items with rename and delete actions inside? The menu can be hidden until the item is hovered. We can keep the double click as a shortcut.

The actions we can add:

  • delete page
  • rename page
  • change display name
  • ...?

@Janpot Janpot added the good first issue Great for first contributions. Enable to learn the contribution process. label Feb 8, 2024
@apedroferreira

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: ux Design good first issue Great for first contributions. Enable to learn the contribution process. priority: low To delay as much as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants