Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Account] Rename menuItems slot to popoverContent #4179

Closed
Janpot opened this issue Oct 2, 2024 · 1 comment · Fixed by #4181
Closed

[Account] Rename menuItems slot to popoverContent #4179

Janpot opened this issue Oct 2, 2024 · 1 comment · Fixed by #4181
Assignees
@bharatkashyap
Labels
docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature scope: toolpad-core Abbreviated to "core"

Comments

@Janpot
Copy link
Member

Janpot commented Oct 2, 2024 •
edited
Loading

Steps to reproduce

"menuItems" is confusing, it sounds like the only thing you can render in there is a menu.

Maybe we it could use extra demo with content that is not just a menu?

Current behavior

No response

Expected behavior

No response

Context

https://discord.com/channels/1131323012554174485/1248515176626524200/1290737976934010880

Your environment

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: account customize
@Janpot Janpot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 2, 2024
@bharatkashyap bharatkashyap added docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 2, 2024
@bharatkashyap bharatkashyap mentioned this issue Oct 2, 2024
Merged
9 tasks
@prakhargupta1 prakhargupta1 added the scope: toolpad-core Abbreviated to "core" label Oct 16, 2024
@bharatkashyap bharatkashyap changed the title [Account] Rename menuItems slot to content [Account] Rename menuItems slot to popoverContent Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Completed in MUI Toolpad public roadmap Oct 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharatkashyap bharatkashyap

Labels
docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature scope: toolpad-core Abbreviated to "core"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[account] New slots and sub-components bharatkashyap/mui-toolpad
3 participants
@Janpot @bharatkashyap @prakhargupta1