Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useActivePage using outdated pattern definition #4186

Closed
xinmingzh opened this issue Oct 4, 2024 · 4 comments · Fixed by #4191
Closed

useActivePage using outdated pattern definition #4186

xinmingzh opened this issue Oct 4, 2024 · 4 comments · Fixed by #4191
Labels
bug 🐛 Something doesn't work component: PageContainer scope: toolpad-core Abbreviated to "core"

Comments

@xinmingzh
Copy link

xinmingzh commented Oct 4, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

useActivePage expects pattern to start with leading slash /, but pattern definition is updated to be without leading slash.

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

No response

Search keywords: core
@xinmingzh xinmingzh added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 4, 2024
@Janpot
Copy link
Member

Janpot commented Oct 5, 2024 •
edited
Loading

@xinmingzh I'm not sure I follow. Can you provide a codesandbox that demonstrates the problem?

@xinmingzh
Copy link
Author

https://codesandbox.io/p/sandbox/currying-leaf-pdcksp

Orders nav should be active, but is not active.

@Janpot Janpot mentioned this issue Oct 5, 2024
Merged
@Janpot
Copy link
Member

Janpot commented Oct 5, 2024

Thank you, fixing it in #4191

@Janpot Janpot added bug 🐛 Something doesn't work component: PageContainer scope: toolpad-core Abbreviated to "core" and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@xinmingzh How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: PageContainer scope: toolpad-core Abbreviated to "core"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PageContainer] Remove leading slash from patterns for PageContainer Janpot/mui-toolpad
2 participants
@Janpot @xinmingzh