Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Docs/demo cleanup #4268

Merged
merged 8 commits into from
Oct 17, 2024
Merged

[docs] Docs/demo cleanup #4268

merged 8 commits into from
Oct 17, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Oct 16, 2024 •
edited
Loading

  • Add rule not to import directly from @toolpad/core in docs similar to @mui/material rule in Material UI repo
  • Fix all imports in docs accordingly
  • Use new useDemoRouter hook in every demo where it's possible

To check if nothing is broken (everything seems fine from what I've checked):
https://deploy-preview-4268--mui-toolpad-docs.netlify.app/toolpad/core/react-dashboard-layout/

@apedroferreira apedroferreira added the docs Improvements or additions to the documentation label Oct 16, 2024
@apedroferreira apedroferreira self-assigned this Oct 16, 2024
@apedroferreira apedroferreira marked this pull request as ready for review October 17, 2024 11:27
@apedroferreira apedroferreira requested a review from a team October 17, 2024 11:28
Janpot
Janpot approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Also noticed we have both /internal and /internals. Maybe we should unify them?

@apedroferreira
Copy link
Member Author

Great!

Also noticed we have both /internal and /internals. Maybe we should unify them?

I guess this should do? 9896d0d

@apedroferreira apedroferreira mentioned this pull request Oct 17, 2024
Merged
9 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 17, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 17, 2024
@apedroferreira apedroferreira merged commit fe34483 into mui:master Oct 17, 2024
14 checks passed
@apedroferreira apedroferreira deleted the core-docs-cleanup branch October 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

@apedroferreira apedroferreira

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apedroferreira @Janpot