Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Expose DashboardSidebarSubNavigation at slotprops #4269

Closed
H01001000 opened this issue Oct 16, 2024 · 3 comments
Closed

[core] Expose DashboardSidebarSubNavigation at slotprops #4269

H01001000 opened this issue Oct 16, 2024 · 3 comments

Comments

@H01001000
Copy link

H01001000 commented Oct 16, 2024

Summary

Expose DashboardSidebarSubNavigation as slot and slotprops, allow using non hardcoded (shared/link component) for sidebar

Examples

import Link from "next/link"
<DashboardLayout slotProps={{sidebarSubNavigation: {LinkComponent: Link} }}>
...

Motivation

Currently when navigating between the page with sidebar, it completely refetch(?) the page and causes state loss (if you collapse the sidebar, it open after click link).

Search keywords: Link, sidebar, dashboard layout

@H01001000 H01001000 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 16, 2024
@H01001000 H01001000 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@H01001000 How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@github-actions github-actions bot removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 16, 2024
@apedroferreira
Copy link
Member

Maybe you were following the first example I had written for Vite & React Router? It did have a sidebar "bug" like that which has been updated/fixed since.
React Router integration will be released soon with v0.8.0 of @toolpad/core, let us know if you still have any issues then!

@H01001000
Copy link
Author

Yea I wasn’t paying attention using the default app provider for next js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants