-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option for SignInPage to skip the stack with "Remember Me" and "Forgot Password" #4572
Comments
Sounds good. I feel like the "Remember Me" checkbox shouldn't be there by default at all - instead, we can export a |
@bharatkashyap I'd agree. It would be much simpler to use the component as a composite with slots, instead of configuration based. Some slots can be a bit more general purpose, e.g. "area between fields and submit". Btw, "subtitle" and "title" seem to be swapped ("subtitle" is "Sign In" now), should be the other way. Btw, the gap is there even if I set "display: none" for the |
I can't seem to catch where this issue is
Yes, the text field |
Looks like I messed up during my experiments, I can't reproduce it now, please disregard. |
Summary
Currently
<SignInPage slots={{ rememberMe: () => null }} />
results in an empty stack:And a gap between field and button:
Also note the padding on "Password" is off by few pixels, label is shifted down.
Examples
Something like
<SignInPage slots={{ rememberMe: null }} />
and not providing theforgotPasswordLink
.Currently it's not allowed:
Motivation
There are cases when users should not be presented neither with "Remember Me" nor "Forgot Password". The stack is unconditional now:
Search keywords: SignInPage Stack
The text was updated successfully, but these errors were encountered: