Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error reporting #998

Closed
2 tasks done
apedroferreira opened this issue Sep 14, 2022 · 5 comments · Fixed by #1043
Closed
2 tasks done

Add error reporting #998

apedroferreira opened this issue Sep 14, 2022 · 5 comments · Fixed by #1043
Assignees
Labels
core Infrastructure work going on behind the scenes

Comments

@apedroferreira
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

From #592.
Add automatic error reporting to Toolpad.

Examples 🌈

I'm most familiar with Sentry but feel free to suggest others.
The basic Next.js integration should probably be enough to start with?

Motivation 🔦

No response

@apedroferreira apedroferreira added status: waiting for maintainer These issues haven't been looked at yet by a maintainer website Related to the marketing pages and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 14, 2022
@bytasv
Copy link
Contributor

bytasv commented Sep 14, 2022

I'm also familiar with sentry, so I think it could be a safe bet. The main question would be if we can use that both in online and self-hosted versions and also how the pricing would be calculated or what would that be at all 🤔

I guess since this might lead to a server that we need to pay for we might need a bit more elaborate investigation? @oliviertassinari wdyt?

@Janpot
Copy link
Member

Janpot commented Sep 14, 2022

I'm fine with Sentry. I think we can disable it for the self-hosted version for now. I'd keep telemetry for self-hosted Toolpad out of scope for this demo feature.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 14, 2022

@apedroferreira We have Sentry set up for https://mui.com/store/. It's in our Tech Stack: https://www.notion.so/mui-org/Sentry-5784d0f006b9464b847953c3b23e5311. Feel free to go ahead by following the previous links to gain access to the MUI Sentry account and to setup a new project. We have a free account for now, with https://github.com/mui/mui-store/pull/216 there should be enough quotas for the demo app. Let me know once we outgrow the free plan and we need to add a credit card.

The basic Next.js integration should probably be enough to start with?

I recall spending a full week around 2018 full integrating Next.js with Sentry. Back then, doing it right was a lot of work. We had a lot of errors that were going through the cracks and others that were noise. A quick & dirty integration would be great.

@oliviertassinari oliviertassinari removed the website Related to the marketing pages label Sep 14, 2022
@apedroferreira apedroferreira added the website Related to the marketing pages label Sep 15, 2022
@oliviertassinari

This comment was marked as resolved.

@apedroferreira

This comment was marked as resolved.

@apedroferreira apedroferreira added core Infrastructure work going on behind the scenes and removed website Related to the marketing pages labels Sep 16, 2022
@apedroferreira apedroferreira self-assigned this Sep 19, 2022
@apedroferreira apedroferreira mentioned this issue Sep 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants