Skip to content
This repository has been archived by the owner on Oct 17, 2019. It is now read-only.

nheko doesn't allow the window manager to resize it to custom widths and heights #187

Closed
PureTryOut opened this issue Dec 30, 2017 · 9 comments

Comments

@PureTryOut
Copy link
Contributor

System:

  • Nheko commit/version: 5e0fbe8
  • Operating System: Gentoo Linux
  • Qt version: 5.7.1
  • C++ compiler: GCC6.4
  • Desktop Environment: Xfce with the Xfwm window manager

Actual behavior

Dragging a window to the left or right side of the screen (or using the "Tile window to the {left, right}" option of Xfwm), the window just moves and nothing resizes.

Expected behavior

The window to resize to half the size of the screen (by the window manager).

Steps to reproduce

Set a hotkey for the "Tile window to the {left, right}" option in Xfwm, use it when having nheko focussed. Notice it won't resize (or move).

@mujx
Copy link
Owner

mujx commented Dec 30, 2017

Possibly related to #160 or #163?

@PureTryOut
Copy link
Contributor Author

PureTryOut commented Dec 30, 2017

Possibly? The width it should be resized too is bigger than the minimum width of the application though. For reference, the window would be 1920 / 2 = 960 pixels wide. I personally don't think this has anything to do with the minimum width and height.

@Ralith
Copy link
Contributor

Ralith commented Dec 30, 2017

FWIW, nheko plays just fine in a tiling window manager. In general, X11 window managers can unilaterally clobber the geometry of a window; the window's requests are merely suggestions. Sounds like this is something weird about Xfwm.

@alphapapa
Copy link
Contributor

@Ralith I don't think it's that simple. I use KDE/KWin, and I can't make nheko's window smaller than a certain size. I don't have this problem with other apps.

@Ralith
Copy link
Contributor

Ralith commented Jan 15, 2018

It is that simple. It's your WM's decision to respect a minimum size requested by the application.

@alphapapa
Copy link
Contributor

alphapapa commented Jan 16, 2018

Ok, so why is nheko requesting that minimum size? Here's an example:
nheko1
There's plenty of whitespace, so there should be plenty of room for me to make the window smaller.

I even opened KWin's special window settings and turned on the overrides:
nheko2
And I still can't make the nheko window any smaller than it is. I drag the lower-right corner of the window up and to the left, and nothing happens beyond this size.

Finally by explicitly overriding the "minimum size", I'm able to shrink it further:
nheko3

nheko4

But I don't think users should have to override things in their window manager (only possible on X, anyway) to do this.

@mujx
Copy link
Owner

mujx commented Jan 16, 2018

Hmm maybe that minimum size is imposed by the settings page.

@PureTryOut
Copy link
Contributor Author

Preferably nheko acts like Telegram, resizing itself to a mobile layout of some sorts. As @alphapapa showed in his last screenshot, nheko still looks quite good when resized to be that small.

@alphapapa
Copy link
Contributor

@PureTryOut You're right, it mostly does. However, sometimes messages do not get wrapped, and instead they are truncated past the edge of the screen, which also pushes the newly right-aligned timestamps off the screen. This happens even without overriding the minimum size, though, so I think there's a minor bug. I haven't discovered a pattern yet, so I haven't reported it yet.

@mujx mujx closed this as completed in d56446c Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants