Skip to content
This repository has been archived by the owner on Oct 17, 2019. It is now read-only.

version numbers broken on macOS #423

Closed
core-code opened this issue Aug 30, 2018 · 5 comments
Closed

version numbers broken on macOS #423

core-code opened this issue Aug 30, 2018 · 5 comments

Comments

@core-code
Copy link

i've downloaded Version '0.5.4' and version 0.5.2 but when selecting it in the Finder and using 'Get Info' it always shows Version '0.5'

@mujx
Copy link
Owner

mujx commented Aug 31, 2018

How did you install it? Do you have both versions installed?

You can check in the /Applications directory.

@mujx
Copy link
Owner

mujx commented Aug 31, 2018

In the bundle there are two versions (long & short). So you're probably referring to short.

@core-code
Copy link
Author

core-code commented Aug 31, 2018

here are the Info.plist entries from the last 4 releases (official downloads from bintray.com/mujx/matrix/nheko):

0.5.1
    <key>CFBundleShortVersionString</key>
    <string>0.5</string>
    <key>CFBundleVersion</key>
    <string></string>

0.5.2
    <key>CFBundleShortVersionString</key>
    <string>0.5</string>
    <key>CFBundleVersion</key>
    <string></string>

0.5.3
    <key>CFBundleShortVersionString</key>
    <string>0.5</string>
    <key>CFBundleVersion</key>
    <string></string>

0.5.4
    <key>CFBundleShortVersionString</key>
    <string>0.5</string>
    <key>CFBundleVersion</key>
    <string></string>

so we see two problems.
1.) the CFBundleShortVersionString isn't aligned with the real version. it should read 0.5.4 for the 0.5.4 release instead of 0.5
2.) the CFBundleVersion is just empty. if you don't have build-numbers it should be set to the same value as the CFBundleShortVersionString

@mujx mujx closed this as completed in 3de650d Aug 31, 2018
@core-code
Copy link
Author

awesome, thanks!

@core-code
Copy link
Author

i can confirm that this bug is fixed in the released version 0.5.5

thanks again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants