-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source env_vars.sh in the test docker container #198
Conversation
Again - so sorry to be slow to get back to you. Would you mind updating the README to say that |
@anthrotype Are you sure it's going to be specifically Then, for the advertized TOXENV use case, you'll need to somehow "know" about the outside variables anyway since you're going to set TOXENV conditionally. So, I suspect that using the functionality as suggested is going to be really awkward. It would very much help if you override some of Multibuild's functionality privately in your repo (by |
Hi! I'm afraid I won't have time to work in this, but feel free to use/discard/continue as you see fit. Sorry, thanks! |
I guess we could just add a |
Well, yes, but I don't see a use case for a separate script file here. The purpose of But in the case of testing, there's no stock logic to speak of: all it does is |
So there's nothing it can do that So AFAICS at this point, it's going to confuse users and do more harm than good. |
Ok to close this one? |
Closing. Please reopen if a use case arises. |
... similarly to how it's done in the build phase.
Fixes https://github.com/matthew-brett/multibuild/issues/197