Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update qemu-binfmt-conf.sh to support loongarch64 #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangguanzhang
Copy link

@zhangguanzhang zhangguanzhang commented Mar 6, 2023

Fixes: #188

Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
@zhangguanzhang
Copy link
Author

zhangguanzhang commented Mar 6, 2023

@lafin PTAL

@loongson-zn
Copy link

loongson-zn commented Dec 4, 2023

@lafin What ideas do you have for supporting LoongArch? multiarch/qemu-user-static is important in cross world, looking forward to supporting LoongArch.
I have verified it's correct through LoongArch sbuildQEMU on debian community.

@@ -1,7 +1,7 @@
#!/bin/sh

QEMU_BIN_DIR=${QEMU_BIN_DIR:-/usr/bin}

QEMU_SUFFIX=${QEMU_SUFFIX:--static}
Copy link

@leavelet leavelet May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qemu-user-static shoud be statically linked. Simply rename qemu-user to qemu-user-static will not work as expected. So -static suffix is not optional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qemu-user-static shoud be statically linked. Simply rename qemu-user to qemu-user-static will not work as expected. So -static suffix is not optional.

This was the default behavior before. I just added the variable default value so that it can be configured through variables.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the default value should be changed. -static is necessary for binfmt to work properly.

@gaosong-loongson
Copy link

@zhangguanzhang Could you update the commit? QEMU 9.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to upgrade to support loongarch64
4 participants