Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Warn when toString behavior will be different. #124

Open
Gozala opened this issue Aug 7, 2020 · 2 comments
Open

Warn when toString behavior will be different. #124

Gozala opened this issue Aug 7, 2020 · 2 comments
Assignees
Labels
status/ready Ready to be worked

Comments

@Gozala
Copy link
Contributor

Gozala commented Aug 7, 2020

js-multiformats introduced more deterministic behavior of toString() method which could lead to a different behavior in comparison to .toString() method here.

We should amend .toString() method implementation here to print a warning in instances where behavior exhibited by js-multiformats would defer and provide a link to migration guide.

@Gozala
Copy link
Contributor Author

Gozala commented Aug 7, 2020

@mikeal I've assigned it to you because I think you're only one who actually understands this.

@Gozala
Copy link
Contributor Author

Gozala commented Aug 7, 2020

I think we should make sure that warning printed is actionable in some way e.g. users can opt-in into future behavior otherwise it's just going to be annoyance.

@Gozala Gozala added the status/ready Ready to be worked label Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants