Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TLS to protocols-table #306

Merged
merged 3 commits into from
Jan 30, 2023
Merged

feat: add TLS to protocols-table #306

merged 3 commits into from
Jan 30, 2023

Conversation

MarcoPolo
Copy link
Contributor

This allows the construction of /tls/ws which is identical and preferred to /wss. Similar with /http

@achingbrain achingbrain changed the title Add TLS to protocols-table feat: add TLS to protocols-table Jan 30, 2023
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs an extra assertion added to the 'throws an error' test to ensure the expected error is being thrown

test/index.spec.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 50bb433 into master Jan 30, 2023
@achingbrain achingbrain deleted the marco/tls branch January 30, 2023 18:11
github-actions bot pushed a commit that referenced this pull request Jan 30, 2023
## [11.4.0](v11.3.0...v11.4.0) (2023-01-30)

### Features

* add TLS to protocols-table ([#306](#306)) ([50bb433](50bb433))
@github-actions
Copy link

🎉 This PR is included in version 11.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants