Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onion support #89

Merged
merged 9 commits into from
Jun 5, 2019
Merged

Onion support #89

merged 9 commits into from
Jun 5, 2019

Conversation

ricott1
Copy link
Contributor

@ricott1 ricott1 commented Jun 5, 2019

I solved Issue #88 , testing against the python implementation to ensure we get the right result.

@ricott1 ricott1 mentioned this pull request Jun 5, 2019
Closed
jacobheun
jacobheun approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up some tests for bad onion addresses, this looks good.

I think the convert.js structure needs to be revisited in the near future to improve scalability there. As more address types are added it's going to get more difficult to maintain/update.

@jacobheun jacobheun merged commit b606df3 into multiformats:master Jun 5, 2019
@filips123 filips123 mentioned this pull request Jul 22, 2019
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricott1 @jacobheun