Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

fix: dont mutate select protocols #55

Merged
merged 1 commit into from
Oct 31, 2019
Merged

fix: dont mutate select protocols #55

merged 1 commit into from
Oct 31, 2019

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Oct 31, 2019

When passed as an array, .select was mutating the protocol list by calling shift. This fixes that by internally using a clone of the array.

@jacobheun jacobheun merged commit 662b5fd into master Oct 31, 2019
@jacobheun jacobheun deleted the fix/param-mutation branch October 31, 2019 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants