You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems reasonable to me. I recall @mikeal wanted to go about this in a different way though especially for JS, by making the codecs you pull into your library more configurable. IIUC the purpose was to decrease the bundle size of applications, but I'll let him correct me and fill in the blanks here.
An interesting possible counterpoint to automation is the renaming of the recently added 0xcert to zeroxcert which would have been a breaking change for js-multicodec had it been in there before the change.
But yeah, the two other commits to base-table.js in js-multicodec this year were by consumers of the library to just add the specific codecs they wanted, not updating the whole table. That doesn't seem like an ideal pattern. I guess a +1 to a regular or semi-regular basis to open PRs against the relevant libraries. Probably not auto merging or releasing.
Right now we need to manually update tables in JS/GO implementations:
This is pretty bad for IPFS/IPLD ecosystem because we often run into situation where different implementations understand different subset of the table (recent example: multiformats/multihash#129 (comment) + multiformats/js-multicodec#62).
Here is an idea:
Create a Github Action that runs daily, detects multicodec table changes and either opens issues or PRs against client repos.
cc @ribasushi @vmx @rvagg @aschmahmann @jacobheun @olizilla @autonome
Thoughts?
The text was updated successfully, but these errors were encountered: