Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate codec updates across libraries #183

Open
lidel opened this issue Jul 21, 2020 · 2 comments
Open

Automate codec updates across libraries #183

lidel opened this issue Jul 21, 2020 · 2 comments

Comments

@lidel
Copy link
Member

lidel commented Jul 21, 2020

Right now we need to manually update tables in JS/GO implementations:

This is pretty bad for IPFS/IPLD ecosystem because we often run into situation where different implementations understand different subset of the table (recent example: multiformats/multihash#129 (comment) + multiformats/js-multicodec#62).

Here is an idea:

Create a Github Action that runs daily, detects multicodec table changes and either opens issues or PRs against client repos.

cc @ribasushi @vmx @rvagg @aschmahmann @jacobheun @olizilla @autonome

Thoughts?

@aschmahmann
Copy link

Seems reasonable to me. I recall @mikeal wanted to go about this in a different way though especially for JS, by making the codecs you pull into your library more configurable. IIUC the purpose was to decrease the bundle size of applications, but I'll let him correct me and fill in the blanks here.

@rvagg
Copy link
Member

rvagg commented Jul 21, 2020

An interesting possible counterpoint to automation is the renaming of the recently added 0xcert to zeroxcert which would have been a breaking change for js-multicodec had it been in there before the change.

But yeah, the two other commits to base-table.js in js-multicodec this year were by consumers of the library to just add the specific codecs they wanted, not updating the whole table. That doesn't seem like an ideal pattern. I guess a +1 to a regular or semi-regular basis to open PRs against the relevant libraries. Probably not auto merging or releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@lidel @rvagg @aschmahmann and others