-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jvm based multihash implementations should coordinate namespaces #98
Comments
@Stebalien @ianopolous @changjiashuai @tdiesler Seeing as this issue is floating around a bit, I understand not everyone uses Maven but it is still a major component of the ecosystem it would be great to sort this out. This issue applies to more than just multihash but it is here as I noticed it here first :). Would love to here peoples thoughts? |
I don't really see any way forward here that'll make everyone happy but I'd use the language names (e.g., rename the kotlin one to |
An obvious solution would be to move away from JitPack and publish on Maven central (like most other OS Java projects do). AFAICS, it is JitPack that mandates a certain group/artifactId for stuff that it publishes. Moving to Maven central would give full control over group/artifactId and of course package name. |
The JVM can easily handle loading things with the same package and even class name, using different class loaders. I suspect once we migrate to Java 9+ this will be a non problem because each implementation would have a distinct module. |
I just noticed that the java implementation has the namespace
io.ipfs.multihash
and the kotlin implementation hasio.ipfs.multiformats.multihash
.Ideally, all jvm multiformats implementations would live in peace and harmony and fall under the same namespace, i.e.
io.ipfs.multiformats
, and then be distinguished by language and project, i.ejava-multihash
,kt-multihash
,clj-multihash
etc. This may only be realistic for implementations that get brought into themultiformats
github org.The text was updated successfully, but these errors were encountered: