Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate using Pydantic models #9

Open
multimeric opened this issue Aug 3, 2022 · 0 comments
Open

Investigate using Pydantic models #9

multimeric opened this issue Aug 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@multimeric
Copy link
Owner

In theory we could replace all the TypedDict with pydantic models.

Advantages:

  • Could implement advanced validation like regex etc
  • Could have low level models for things like ranges

Disadvantages:

  • More dependencies, so larger installation
  • Much more verbose queries. You would now have to import the appropriate models instead of just using built-in Python constructs
@multimeric multimeric added the enhancement New feature or request label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@multimeric