Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumukit skips expectations when content is interpolated into extra #114

Open
julian-berbel opened this issue Aug 30, 2021 · 0 comments
Open

Comments

@julian-berbel
Copy link
Member

Here we skip running expectations when request content is empty:

request.expectations.nil? || (request.content.nil? && !Mumukit.config.process_expectations_on_empty_content)

But this causes conflicts with requests where content is interpolated into the extra. A request like the following:

content:

def foo
  puts 'printing to console!'
end

extra:

class Bar
#...content...#
end

will come back with no smells as extra "swallows" content, which leaves it empty for the aforementioned check.

Maybe we could run these checks before interpolations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant