Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to have a minimum severity level for annotations #391

Closed
ashek-simeon opened this issue Jun 10, 2023 · 5 comments
Closed

Request to have a minimum severity level for annotations #391

ashek-simeon opened this issue Jun 10, 2023 · 5 comments

Comments

@ashek-simeon
Copy link

Right now, it does not seem that there is a way to, for instance, only show annotations for warnings and above.

Possibly this could be achieved by adding a new parameter to the action, and passing it to the --severity option of jb inspectcode.

Thanks for your consideration!

@muno92
Copy link
Owner

muno92 commented Jun 11, 2023

@ashek-simeon
Thank you for suggestion!

I add option minimumReportSeverity on version 1.7.0 .
So, you can specify minimum annotation level with version 1.7.0 or higher.

Regards.

@ashek-simeon
Copy link
Author

Thank you so much - I am excited to use this new parameter! Amazing!

As one minor note - In the readme I think there may be a typo where the new parameter is named minimumSeverity instead of minimumReportSeverity

@muno92
Copy link
Owner

muno92 commented Jun 12, 2023

It's not typo...

minimumSeverity is another option to specify action failure level.
You can use this option when annotation target is different from issue level what you want to fail job.

The following is example.

  • minimumSeverity
    • warning
  • minimumReportSeverity
    • info

Output

  • annotation
    • info or higher
  • inspection job failed
    • when warning or error is exists

I think it is too confusing, but for backward compatibility, I keep both option while 1.x.

@ashek-simeon
Copy link
Author

I meant that it looks like minimumSeverity is listed twice

image

@muno92
Copy link
Owner

muno92 commented Jun 12, 2023

Oh, it's typo.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants