Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add front side console error when conversion fails #65

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

murgatt
Copy link
Owner

@murgatt murgatt commented Nov 28, 2020

Description

When a conversion error occurred there is no way to see the details of what happened.
This PR add a console error on the front side to display the server side error.

How to test

Do something wrong to trigger an error during conversion
Start the conversion and open the development console to see the error

Checklist

  • My code follows the code style of this project
  • My change requires a change to the translations
  • I have updated the translation files accordingly

@murgatt murgatt added the enhancement New feature or request label Nov 28, 2020
@murgatt murgatt self-assigned this Nov 28, 2020
@murgatt murgatt merged commit ce1647e into master Nov 28, 2020
@murgatt murgatt deleted the front-conversion-error branch November 28, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant