Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for enabling plugins or assigning them to "extension points" is unclear and needs design #23421

Closed
cbjeukendrup opened this issue Jul 1, 2024 · 3 comments
Assignees
Labels
needs design Design is needed P1 Priority: High plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) regression nightly Works correctly in the latest released version and is broken in the nightly builds UI Visual issues affecting the UI (not notation)

Comments

@cbjeukendrup
Copy link
Contributor

Issue type

UI bug (incorrect info or interface appearance)

Bug description

In the panel to manage a plugin's shortcut and enabledness, there is now a dropdown to enable a plugin or assign it to an "extension point".

This will need a UI design pass. The main problems with it are the following:

  • It isn't clear that "Manually" is the new "Enabled"
  • The other options are badly worded ("On post/pre …" is not correct English)
  • The user has no way to understand what these options do.

Also, I'm personally still of the opinion that this is not the right way to present these "extension points" to the user. Instead, I'd prefer to see it as a sort of "if this than that" style automation, where you see a list of possible triggers and then assign plugins or other actions to these triggers. Now, it feels like it's the wrong way around, where you have to assign a trigger to a plugin.

Steps to reproduce

  1. Open Home > Plugins
  2. Click a plugin to see the panel appear

Screenshots/Screen recordings

Scherm­afbeelding 2024-07-01 om 16 56 13

MuseScore Version

master (4.4)

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

*

Additional context

No response

@cbjeukendrup cbjeukendrup added needs design Design is needed plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) labels Jul 1, 2024
@muse-bot muse-bot added regression MS4 Regression on a prior release UI Visual issues affecting the UI (not notation) labels Jul 1, 2024
@bkunda bkunda added the P1 Priority: High label Jul 2, 2024
@bkunda bkunda assigned avvvvve and unassigned Eism Jul 2, 2024
@TeeDeeY
Copy link

TeeDeeY commented Jul 5, 2024

A related issue is that setting title: “title” conditionally in version 4.4 in the “onCompleted” section no longer works. The Jan 4 version has the changes described here and title in the menu doesn’t work, conditionally. Late June 4.4 does work.

Since I don’t know the design goals, it’s difficult to comment. But, using conditional logic allows one plug-in to load in versions 3.6, 4.2 and 4.4, assuming other components are also compatible.

If this should be reported and documented separately, please tell me. It could be that titles go away by design, making posting pointless.

@cbjeukendrup
Copy link
Contributor Author

That is more related to #23419, but I think it would be good to open a new issue for that.
The idea is not to remove the concept of plugin titles, but the old API will be deprecated at some point.
However, for 4.4 there shouldn't really be any changes. The reason that you're still seeing some regressions in the latest nightly builds, is that development of the new API has already started. We'll try our best to minimise the amount of regressions before the final 4.4 release.
(An official announcement about the developments around the plugins API will follow soon.)

@cbjeukendrup cbjeukendrup added regression nightly Works correctly in the latest released version and is broken in the nightly builds and removed regression MS4 Regression on a prior release labels Jul 17, 2024
@bkunda
Copy link

bkunda commented Aug 20, 2024

This was reverted by @igorkorsukov so it no longer appears in 4.4.
We'll be working on a proper design solution to present these triggers to users for 4.5.

@musescore musescore locked and limited conversation to collaborators Aug 20, 2024
@bkunda bkunda converted this issue into discussion #24107 Aug 20, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
needs design Design is needed P1 Priority: High plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) regression nightly Works correctly in the latest released version and is broken in the nightly builds UI Visual issues affecting the UI (not notation)
Projects
None yet
Development

No branches or pull requests

6 participants