Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython not required #10

Open
buffer opened this issue Aug 12, 2014 · 0 comments
Open

Cython not required #10

buffer opened this issue Aug 12, 2014 · 0 comments

Comments

@buffer
Copy link

buffer commented Aug 12, 2014

While taking a look at setup.py and requirements.txt I realized that they are not correctly defined.
Cython should be used just for generating pylibinjection.c so the following lines

sourcefiles = [
    'src/pylibinjection.pyx',
    'submodules/libinjection/c/libinjection_sqli.c'
]

should be

sourcefiles = [
    'src/pylibinjection.c',
    'submodules/libinjection/c/libinjection_sqli.c'
]

and the user is not required to install Cython at all. Please take a look at pylibemu setup.py for an example. In such case I temporarly decomment the lines and set sourcefiles to the .pyx just for producing the .c file. That avoids the end user installing Cython. If needed I can produce a patch for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant