Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Radio mode for Subsonic and remove Podcast hacks #1774

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

khers
Copy link
Contributor

@khers khers commented Nov 8, 2024

Don't stop the music was failing due to a typo when calling get_similar_songs(), fix the typo to enable this mode.

There is a model refactor coming that will add Podcasts as first class objects to MA so none of this code that tries to wedge them into the Artist/Album/Track model is necessary. Tear out the dead code.

Don't stop the music was failing due to a typo when calling
get_similar_songs(), fix the typo to enable this mode.

There is a model refactor coming that will add Podcasts as first class
objects to MA so none of this code that tries to wedge them into the
Artist/Album/Track model is necessary. Tear out the dead code.

Signed-off-by: Eric B Munson <eric@munsonfam.org>
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marcelveldt marcelveldt merged commit da42973 into music-assistant:dev Nov 8, 2024
2 of 3 checks passed
@marcelveldt marcelveldt changed the title Fix Don't Stop the Music for Subsonic and remove Podcast hacks Fix Radio mode for Subsonic and remove Podcast hacks Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants