Support html/template

[xeoncross]

It looks like there is no option for returning HTML/templates.

Can we add a check for this?

type IndexHandler struct{}

func (m *IndexHandler) Handle(c *gongular.Context) (err error) {
	var indexHTML = `<h1>Hello World</h1>`
	var tmpl *template.Template
	tmpl, err = template.New("index").Parse(indexHTML)
	c.SetBody(tmpl)
	return
}

The work around is to manually set the header and return []byte.

c.Header("Content-Type", "text/html")
c.SetBody([]byte(indexHTML))

Possible Solution:

if v, ok := a.(*template.Template); ok {
	c.w.WriteHeader(c.status)
	err := v.Execute(c.w)
	if err != nil {
		c.logger.Println("Could not write the response", err)
	}
	return 1 // todo?
}

[mustafaakin]

Not having used templates myself, I did not even think about it. Do you have anything to propose? Are templates cached? If we add a field as *template.Template to handler, or left it to user? Templates can be passed with dependency injections.

For plain HTML, I can implement:

c.SetHtml(..)

as a shortcut for:

c.Header("Content-Type", "text/html")
c.SetBody([]byte(indexHTML))

[xeoncross]

Well, the nice thing would be for the system to handle *template.Template for you. Since Templates almost always need params, having a SetHtml() seems wasteful as you would 1) have to manually load and compile templates in each handler (compare with automatic JSON responses) and 2) you would end up passing large byte streams/slices around multiple times causing wasted GC and allocs.

My prosed type-check solution up above assumes the templates have no params from the handler/context which isn't normal:

tmpl, err := template.New("name").Parse(`Name: {{.Name}}`)
err = tmpl.Execute(c.w, struct{Name string}{Name: "John"})