Initialization refactoring & improvements

[dimazen]

Replace initializing code into initWithNibName:bundle:.
Before that if we're using [MMDrawerController new]; - no setup occured and different options stay uninitialized.

Also i move [self.view setBackgroundColor:]; & gesture recognizers setup to viewDidLoad:
Calling self.view in init leads to view load & inefficient resources usage.

[kcharwood]

Thanks for submitting the pull request. I'm curious to hear more about your last point. We're you running into real performance issues, or is this just more of a best practice?

I haven't noticed any issues on my end with that.

[larsacus]

How is this different from calling self = [self init] for the situation you're running into? According to the documentation for initWithNibName:bundle:, init should call initWithNibName:bundle: with nil parameters:

If you subclass UIViewController, you must call the super implementation of this
method, even if you aren't using a NIB. (As a convenience, the default init method will do this for you,
and specify nil for both of this methods arguments.)

[dimazen]

Well, there is actually no performance problems, you're right :)
It's kind of a best practice in terms of performance in general. Apple recommends to write init methods as efficient as possible. View allocation may take additional time (additional memory allocation, nib instatiation, etc).

[dimazen]

@larsacus
Sorry, not sure, that i get your question.
Something wrong with my commit or..? :)
Thanks in advance

[larsacus]

I'm just posing this question. We probably need initWithNibName:bundle: to support storyboards, but I'm just trying to figure out why this was necessary for the specific case you're describing.

[kcharwood]

I'm guessing that since initWithNibName:bundle: is the designated initializer for UIViewController, calling [MMDrawerController new] does not go through our designated initializer, which leaves a bunch of properties uninitialized.

[dimazen]

@larsacus
Ok, let me describe.
I'm instatiating MMDrawerController from code, but central contoller is unknown for this moment - it will be setted later. Therefore i've decided to move some config code intro initWithNibName:bundle: to support alloc/init

Also, if we're instantiating controller from XIB - we also in trouble because of unconfiguret properties

That was the case :)

[kcharwood]

Docs from Apple on a designated initializer:

The designated initializer plays an important role for a class. It ensures that inherited instance variables are initialized by invoking the designated initializer of the superclass.

I think we may actually need to be calling super initWithNibName:bundle:...

[dimazen]

@kcharwood
it's already done. Probably it require some additional change for storyboard support :^)

[larsacus]

We're still investigating storyboard support in #33, but this looks like a needed change regardless.

Yet another reason to stay away from [UIViewController new], though, IMO...

[kcharwood]

I merged this in with 90582bf, and will get you credit in the changelog in the 0.2.0.

Thanks for the pull!