Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add currentPdt getter and getStartDate() method #661

Merged
merged 9 commits into from
Apr 14, 2023

Conversation

gkatsev
Copy link
Contributor

@gkatsev gkatsev commented Apr 12, 2023

No description provided.

@gkatsev gkatsev requested a review from a team as a code owner April 12, 2023 22:02
@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 0:09am
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 0:09am
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 0:09am
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 0:09am
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 0:09am

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #661 (98827de) into main (db4cc9f) will increase coverage by 0.10%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   84.72%   84.82%   +0.10%     
==========================================
  Files          39       40       +1     
  Lines        7967     8035      +68     
  Branches      452      453       +1     
==========================================
+ Hits         6750     6816      +66     
- Misses       1210     1212       +2     
  Partials        7        7              
Impacted Files Coverage Δ
packages/mux-player/src/index.ts 79.49% <50.00%> (-0.17%) ⬇️
packages/mux-audio/src/index.ts 68.83% <100.00%> (+1.36%) ⬆️
packages/mux-video/src/index.ts 68.04% <100.00%> (+0.53%) ⬆️
packages/playback-core/src/index.ts 69.01% <100.00%> (+0.14%) ⬆️
packages/playback-core/src/pdt.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! LGTM

@gkatsev gkatsev merged commit 530170b into muxinc:main Apr 14, 2023
@gkatsev gkatsev deleted the current-pdt branch April 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants