Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS var to set the font family on media-time-display #453

Closed
dylanjha opened this issue Jan 26, 2023 · 4 comments · Fixed by #528
Closed

Add CSS var to set the font family on media-time-display #453

dylanjha opened this issue Jan 26, 2023 · 4 comments · Fixed by #528
Labels
enhancement New feature or request

Comments

@dylanjha
Copy link
Collaborator

dylanjha commented Jan 26, 2023 •
edited
Loading

Seems like this is missing and it should be a thing. I don't see why it wouldn't be?

cc: @davekiss
@gkatsev
Copy link
Contributor

gkatsev commented Jan 26, 2023

There are many things that are missing. Started #447 as a place to work through what's there, what's missing, and how we want to go forward with the css vars.

@luwes luwes added the enhancement New feature or request label Jan 27, 2023
@luwes
Copy link
Contributor

luwes commented Jan 27, 2023

We might as well change the default font while we're at it, Arial is so old school

@luwes
Copy link
Contributor

luwes commented Mar 23, 2023

a valid point against it is that the font-family is inherited from the custom element

SCR-20230323-mk8

but it would still be handy for themes for example

@luwes
Copy link
Contributor

luwes commented Apr 10, 2023

+1 for adding a CSS var for changing the font.

Related glitch fix PR: #526
Related player issue: muxinc/elements#654

@luwes luwes mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve CSS vars luwes/media-chrome
3 participants
@luwes @gkatsev @dylanjha