Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest : expiringIn method #26

Open
AEK-BKF opened this issue Oct 1, 2020 · 3 comments
Open

Suggest : expiringIn method #26

AEK-BKF opened this issue Oct 1, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AEK-BKF
Copy link

AEK-BKF commented Oct 1, 2020

Hello;

Thanks for this nice package.
You may add expiringIn method which is helpful for notifications before expired date.
example:
$subscriptions = App\Models\Subscription::expiringIn('x months/days/hours')->get(); // Get subscriptions will expire in x months/days/hours from now.

Thanks.

@AEK-BKF AEK-BKF added the enhancement New feature or request label Oct 1, 2020
@AEK-BKF AEK-BKF changed the title Suugest : expiringIn method Suggest : expiringIn method Oct 1, 2020
@mvdnbrk
Copy link
Owner

mvdnbrk commented Oct 1, 2020

Nice suggestion, thanks!

@mvdnbrk mvdnbrk self-assigned this Oct 1, 2020
@mvdnbrk mvdnbrk added the good first issue Good for newcomers label Oct 1, 2020
@mvdnbrk mvdnbrk added this to the v1.8.0 milestone Oct 1, 2020
@AEK-BKF
Copy link
Author

AEK-BKF commented Nov 10, 2020

Any updates here :)
Thanks

@mvdnbrk
Copy link
Owner

mvdnbrk commented Nov 10, 2020

Feel free to open a PR to implement this.

@mvdnbrk mvdnbrk removed this from the v1.8.0 milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants