Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Font Awesome <span> technique #33

Closed
HarryAdney opened this issue Mar 11, 2020 · 1 comment
Closed

Support for Font Awesome <span> technique #33

HarryAdney opened this issue Mar 11, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request in progress

Comments

@HarryAdney
Copy link

The extension currently highlights a Font Awesome spans and tags, expecting a role to be added, e.g.
<span class="fa fa-phone pe-color pe-small-icon" role=></span>

If the extension recognised, for instance, aria-hidden='true this would really save a lot of corrective development time.

I've tried adding roles to the spans, but this isn't necessarily a valid option.

@mvdschee mvdschee self-assigned this Mar 13, 2020
@mvdschee mvdschee added enhancement New feature or request in progress labels Mar 13, 2020
@mvdschee
Copy link
Owner

He @HarryAdney I have implemented your request. With the latest update, you should not have any errors if you add aria-hidden="true" to your span

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress
Projects
None yet
Development

No branches or pull requests

2 participants