Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display duplicate entries #17

Open
SpongebobSquamirez opened this issue Sep 16, 2019 · 6 comments
Open

Don't display duplicate entries #17

SpongebobSquamirez opened this issue Sep 16, 2019 · 6 comments
Assignees

Comments

@SpongebobSquamirez
Copy link

For a lot of dictionaries, Qolibri only shows the first part of an entry under a headword unless you read the book data directly. However, even then, it duplicates a lot of parts of entries (sub-headwords?) for these types of dictionaries for some reason:
QolibriFull

(interestingly, the [3] part and the 例文 part are not duplicated)

This means that I can only see less than half of the entries I should be able to at once (this is all supposed to be part of the same entry - EBPocket on my phone displays this stuff fine). It also requires I develop some kind of skill for skipping over the duplicates.

(dictionary in the picture is the 日本語表現活用辞典 EPWING, if you have it)

@mvf
Copy link
Owner

mvf commented Sep 18, 2019

Many thanks for the detailed report. I can reproduce the problem. The duplicate entries are certainly annoying, but personally I find the missing ones even more serious.

@mvf mvf added the bug label Sep 18, 2019
@SpongebobSquamirez
Copy link
Author

Thanks for responding! Glad the issue got noticed.
EBWin4 and its equivalents seems to display everything well, if you want something on desktop to test with.

@mvf mvf added the libeb label Mar 7, 2020
@pkmkb005
Copy link

pkmkb005 commented Mar 22, 2020

It's also perfectly being rendered in DDwin and Logophile. So it must be an issue with libeb itself.
Edit: The dictionary is properly being rendered in Digdic
digdic

Digdic also uses eb library and is open source. https://osdn.net/projects/digdic/
If possible please take a look at the source code. Unfortunately I'm not a programmer and don't know anything about programming, just made this account to report this issue.

@mvf
Copy link
Owner

mvf commented Apr 12, 2020

@pkmkb005 You are a legend, thanks so much for this great info! I wasn't aware of DigDic. I had only tested with EBView and it renders the same as qolibri, so I was convinced this was a libeb issue.

I just coerced DigDic into building and running on modern Linux and it does indeed render correctly. So this should be fixable in qolibri itself after all.

(Sorry I only saw this today by accident. Editing a comment without adding a @mention doesn't send an email notification.)

@mvf
Copy link
Owner

mvf commented Apr 12, 2020

Being able to debug digdic and qolibri side by side, I now have some idea why the search result is cut off. Haven't yet looked at the duplication when reading the whole book. I really hope this can be fixed cleanly without extensive rewrites... WIP screenshot:

issue17

@mvf mvf self-assigned this Apr 12, 2020
@pkmkb005
Copy link

@mvf cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants