Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple windows support #14

Merged
merged 11 commits into from
Apr 10, 2021
Merged

Multiple windows support #14

merged 11 commits into from
Apr 10, 2021

Conversation

vladbat00
Copy link
Owner

@vladbat00 vladbat00 commented Apr 10, 2021

Based on #13

Issues to fix:

  • When a new window is spawned, it acquires the focus, at least on Windows (TODO: test other platforms), but the active context is still the default window. That results in events coming from the second window being consumed by the default context.
  • Clipboard can paste into several fields at the same time if they are all active in different windows.

@vladbat00 vladbat00 self-assigned this Apr 10, 2021
@vladbat00 vladbat00 force-pushed the multiple-windows-support branch from 54b4924 to 9c82634 Compare April 10, 2021 12:17
@vladbat00 vladbat00 force-pushed the multiple-windows-support branch from b7cbeaf to b1cda3c Compare April 10, 2021 12:25
@vladbat00
Copy link
Owner Author

@jakobhellermann I've extended the two windows example a bit and found a couple of minor bugs. I'm looking into them right now, but if you already have an idea on how to fix those, that will help. :)

@jakobhellermann
Copy link
Contributor

@jakobhellermann I've extended the two windows example a bit and found a couple of minor bugs. I'm looking into them right now, but if you already have an idea on how to fix those, that will help. :)

What bugs are there? Running locally seems to work for me.

@vladbat00
Copy link
Owner Author

@jakobhellermann sorry, I forgot to mention that I've described them in the PR body. :) The clipboard issue is now fixed, now I'm trying to figure out what to do with the invalid initial focus.

@vladbat00 vladbat00 force-pushed the multiple-windows-support branch from d1c8bfd to 868537a Compare April 10, 2021 13:07
@jakobhellermann
Copy link
Contributor

On linux the focus doesn't seem to be an issue. The second window gets focused as well, but tab presses etc. get correctly handled in the second window.

@vladbat00
Copy link
Owner Author

Yeah, it looks Windows specific... I wasn't able to reproduce it on my Macbook either.

@vladbat00 vladbat00 force-pushed the multiple-windows-support branch from 2c1a755 to 1ac333a Compare April 10, 2021 14:28
@vladbat00 vladbat00 force-pushed the multiple-windows-support branch from 1ac333a to bf7bd00 Compare April 10, 2021 14:28
@vladbat00 vladbat00 merged commit 99bf2be into main Apr 10, 2021
@vladbat00 vladbat00 deleted the multiple-windows-support branch April 10, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants